Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inline styles assigned in ERB templates #128

Merged
merged 8 commits into from
Nov 12, 2023
Merged

Remove inline styles assigned in ERB templates #128

merged 8 commits into from
Nov 12, 2023

Conversation

mvz
Copy link
Member

@mvz mvz commented Nov 12, 2023

Part of #126.

  • Hide spinner initially with a class
  • Remove superfluous break
  • Hide optional comment form fields with JavaScript
  • Apply tag cloud styling using a class
  • Ensure panel heading height using a class
  • Fix admin flash position without inline styling
  • Initially hide comment feedback elements using a class
  • Group tags into buckets with statically assigned sizes

@mvz
Hide spinner initially with a class
a026ae5
@mvz
Remove superfluous break
9d0b8c3
@mvz
Hide optional comment form fields with JavaScript
68cf5e4 
This changes removes inline styles, and makes the comment form show the
optional fields when JavaScript is disabled. This is a good thing since
otherwise these fields could never be filled in that case.
@mvz
Apply tag cloud styling using a class
98ce17b
@mvz
Ensure panel heading height using a class
bff75ef 
The original break was present to ensure the heading was high enough to
contain the floating search form. Using the clearfix class achieves the
same effect.
@mvz
Fix admin flash position without inline styling
e92f16a
@mvz
Initially hide comment feedback elements using a class
e9a4596
@mvz
Group tags into buckets with statically assigned sizes
e5382f7
@mvz mvz merged commit 63e05f4 into master Nov 12, 2023
5 checks passed
@mvz mvz deleted the remove-inline-styles branch November 12, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mvz